[BUG] Flash\Session::getMessage('key') returns ALL messages

[quasipickle]

I'm calling this a bug, but really it's just undocumented behaviour that I think should be changed.

Anyway, \Phalcon\Flash\Session::getMessage() returns an array of all flashed messages, when no messages of a requested type exist.

For example:

$this->flash->error('test');
$this->flash->warning('test2');
print_r($this->flash('success'));

Will output:

Array
(
    [error] => Array
        (
            [0] => test
        )

    [warning] => Array
        (
            [0] => test2
        )
)

To me this is counter-intuitive. If there are no "success" messages, I would expect getMessages('success') to return NULL or FALSE or at least an empty array. Otherwise there is no way to test if success/warning/etc messages exist.

[phalcon]

Fixed by @sjinks in #920, thanks

[kisb2]

with newest version, this error still exists.... (Windows)

[sergeyklay]

Create separated issue with scrupt to reproduce and Phalcon version