Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlLayoutNode hierarchy: convert traits to classes #580

Closed
tinchodias opened this issue Aug 13, 2024 · 0 comments
Closed

BlLayoutNode hierarchy: convert traits to classes #580

tinchodias opened this issue Aug 13, 2024 · 0 comments

Comments

@tinchodias
Copy link
Collaborator

In the following hierarchy:
Screenshot 2024-08-13 at 10 54 11

this happens:

  • The superclass is EMPTY instance and class side
  • Half of the subclasses have traits: {TBlLayoutNode + TBlLayoutChildNode}
  • The other half have: traits: {TBlLayoutNode + TBlLayoutChildNode}.
  • There aren't any other users of those 3 traits

And it doesn't help to comprehend the code.

So, I propose to:

  • Move all methods of TBlLayoutNode to BlLayoutNode
  • Convert TBlLayoutChildNode to BlLayoutChildNode, and insert it as subclass of TBlLayoutNode and superclass of 4 classes (BlLayoutChildNode*)
  • Same with TBlLayoutParentNode with all BlLayoutParentNode* classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant