a few fixes for warnings about return types

pharo-project · Apr 30, 2024 · a30dd18 · a30dd18
1 parent 5aa6b45
commit a30dd18
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -330,7 +330,6 @@ add_compile_options(
     -Wno-compare-distinct-pointer-types
     -Wno-conditional-type-mismatch
     -Wno-incompatible-function-pointer-types
-    -Wno-return-type
     -Wno-unused-local-typedef
     -Wno-incompatible-pointer-types
     -Wno-shift-negative-value

diff --git a/extracted/plugins/FilePlugin/src/common/sqFilePluginBasicPrims.c b/extracted/plugins/FilePlugin/src/common/sqFilePluginBasicPrims.c
@@ -536,7 +536,7 @@ sqConnectToFile(SQFile *sqFile, void *file, sqInt writeFlag)
  * 4  - stderr available
  */
 sqInt
-sqFileStdioHandlesInto(SQFile files[])
+sqFileStdioHandlesInto(SQFile files[3])
 {
 	/* streams connected to a terminal are supposed to be line-buffered anyway.
 	 * And for some reason this has no effect on e.g. Mac OS X.  So use
@@ -843,6 +843,8 @@ waitForDataonSemaphoreIndex(SQFile *file, sqInt semaphoreIndex){
 	aioEnable(fileno(getFile(file)), (void*) semaphoreIndex, AIO_EXT);
 	typedef void (*aioHandler)(int fd, void *clientData, int flag);
 	aioHandle(fileno(getFile(file)), signalOnDataArrival, AIO_R);
+
+	return interpreterProxy->success(true);
 }
 
 #endif /* NO_STD_FILE_SUPPORT */
diff --git a/ffiTestLibrary/src/callbacks.c b/ffiTestLibrary/src/callbacks.c
@@ -34,7 +34,7 @@ EXPORT(int) reentringCallback(SIMPLE_CALLBACK fun, int base){
 static int value = 0;
 
 #if FEATURE_THREADED_FFI
-void* otherThread(void* aFunction){
+void otherThread(void* aFunction){
 	SIMPLE_CALLBACK f = (SIMPLE_CALLBACK) aFunction;
 
 #ifdef _WIN32