Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not retain any selectors in CogAbstractInstruction #798

Merged
merged 2 commits into from
May 13, 2024
Merged

Do not retain any selectors in CogAbstractInstruction #798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbe5209
Do not retain any selectors in CogAbstractInstruction
RenaudFondeur May 7, 2024
8b4b093
Remove overly conservative requiredMethodNames:
RenaudFondeur May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions smalltalksrc/VMMaker/CogAbstractInstruction.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,16 +288,6 @@ CogAbstractInstruction class >> registerMaskFor: reg1 and: reg2 and: reg3 and: r
^Cogit basicNew registerMaskFor: reg1 and: reg2 and: reg3 and: reg4 and: reg5 and: reg6 and: reg7 and: reg8 and: reg9 and: reg10
]

{ #category : #translation }
CogAbstractInstruction class >> requiredMethodNames: options [
^self selectors reject:
[:s| | m |
(self isAccessor: s)
or: [((m := self compiledMethodAt: s) isQuick and: [m pragmas isEmpty])
or: [(m pragmaAt: #doNotGenerate) notNil
or: [(m pragmaAt: #inline:) notNil and: [(m pragmaAt: #inline:) arguments first == true]]]]]
]

{ #category : #verification }
CogAbstractInstruction class >> specificOpcodes [
^self subclassResponsibility
Expand Down