Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken because of changes in pharo core #1738

Open
demarey opened this issue Sep 29, 2023 · 3 comments
Open

Tests broken because of changes in pharo core #1738

demarey opened this issue Sep 29, 2023 · 3 comments

Comments

@demarey
Copy link
Contributor

demarey commented Sep 29, 2023

tests are now broken because Ring2 (https://github.com/guillep/ring2) needs to be updated to do not use anymore package category

@MarcusDenker
Copy link
Contributor

Why is there even Ring2 as an external project, it is already in Pharo (we have both Ring2 and Ring one loaded)

@MarcusDenker
Copy link
Contributor

(and in a very confusing way, the classes have no RG2 prefix so people confuse Ring1 and Ring2 in the system all the time and might not even be aware that here are two RIngs...)

@demarey
Copy link
Contributor Author

demarey commented Sep 29, 2023

not sure but looks like it is a fork of RIng2 (https://github.com/guillep/ring2).
The fix is as follows:
Screenshot 2023-09-29 at 16 13 57

@sdiepend did the change in https://github.com/sdiepend/Ring2/tree/fix-tests but it cannot be merged in the master branch that evolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants