Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb Component #42

Closed
LeeMellon opened this issue Jul 9, 2021 · 2 comments · Fixed by #96
Closed

Breadcrumb Component #42

LeeMellon opened this issue Jul 9, 2021 · 2 comments · Fixed by #96
Assignees
@sarahp
Labels
Difficulty: Average Severity: Medium Type: Component Suggestion Use this label for any issue that is a recommendation for a specific type of component.

Comments

@LeeMellon
Copy link

LeeMellon commented Jul 9, 2021 •
edited
Loading

Requirements

Create a basic breadcrumb component that:

  • Takes either a data array to render as links, or passes pre-rendered links into a slot.
  • Conforms to accessibility guidelines.

Example

https://designsystem.digital.gov/components/breadcrumb/
Breadcrumb___U_S__Web_Design_System__USWDS_

Accessibility Guidelines

A11y Style Guide
W3.org
@LeeMellon LeeMellon added Type: Enhancement Difficulty: Average Severity: Medium Type: Component Suggestion Use this label for any issue that is a recommendation for a specific type of component. labels Jul 9, 2021
@sarahp sarahp self-assigned this Jul 20, 2021
@sarahp
Copy link
Contributor

sarahp commented Jul 28, 2021 •
edited
Loading

Should we consider doing individual links instead of an array? The problem I'm having is drilling down into the <ol> to do the styling. I could use Tailwind classes if we're able to get that working in the main TS file. Thoughts?

@sarahp sarahp mentioned this issue Aug 10, 2021
Merged
@himerus
Copy link
Contributor

himerus commented Sep 10, 2021

We at least now have the slotted version, and should consider the data array option as an enhancement so we can do both.

This was linked to pull requests Sep 10, 2021
Feature/breadcrumbs #96
Merged
Adding controllers #99
Merged
@himerus himerus removed a link to a pull request Sep 10, 2021
Adding controllers #99
Merged
@himerus himerus closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahp sarahp

Labels
Difficulty: Average Severity: Medium Type: Component Suggestion Use this label for any issue that is a recommendation for a specific type of component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/breadcrumbs phase2/outline
3 participants
@himerus @sarahp @LeeMellon