Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Philhk Vencord Fork is not working because vencord stopped working and stuff needs to be updated #24

Open
2 tasks done
Cxsmo-ai opened this issue Jun 19, 2024 · 26 comments
Labels
bug Something isn't working

Comments

@Cxsmo-ai
Copy link

Discord Account

No response

What happens when the bug or crash occurs?

Philhk Vencord Fork is not working because vencord stopped working and stuff needs to be updated

What is the expected behaviour?

Philhk Vencord Fork is not working because vencord stopped working and stuff needs to be updated

How do you recreate this bug or crash?

Philhk Vencord Fork is not working because vencord stopped working and stuff needs to be updated

Errors

Philhk Vencord Fork is not working because vencord stopped working and stuff needs to be updated

Request Agreement

  • I am using Discord Stable or tried on Stable and this bug happens there as well
  • I have read the requirements for opening an issue above
@Cxsmo-ai Cxsmo-ai added the bug Something isn't working label Jun 19, 2024
@Lioncat6
Copy link

Just build it yourself until they merge it. Just download this repo, copy the plugins and paste them in a download of the main vencord repo.

@Lioncat6
Copy link

philsPluginLibrary
betterMicrophone.desktop
betterScreenshare.desktop
are the plugins that you should copy

@BlueberryWolf
Copy link

you can also use the easy install script on my profile, it merges and builds everything for you

@Lioncat6
Copy link

Neat! Unfortunately I can't use it cause my path variable is fucked lol.

@Killua81
Copy link

betterMicrophone.desktop and betterScreenshare.desktop they don't appear the way they used to. the icons are gone and bettermicrophone no longer works.

I try to use @BlueberryWolf launcher and this is the same.

@BlueberryWolf
Copy link

betterMicrophone.desktop and betterScreenshare.desktop they don't appear the way they used to. the icons are gone and bettermicrophone no longer works.

I try to use @BlueberryWolf launcher and this is the same.

Actually, the plugin never broke, only the UI. I will look into it at some point, I'm just not feeling at it at the moment.

If you still want to use the plugin, you can manually edit the settings json to change your mic and screenshare settings, as only the UI is broken

@Annabxlla
Copy link

Screenshare fully crashes vencord now, and the settings json for better mic has all of its profiles deleted, including the default ones it creates.

Also NTTS made a video about this plugin so discord might patch betterScreenshare

@Cxsmo-ai
Copy link
Author

Cxsmo-ai commented Aug 5, 2024

wondering if yadb4nitro that was worked on to get working with better discord compat for vencord plugin actually works and can be used instead of this because yabdp4nitro works on better discord and was supposedly made to work with that plugin

@BlueberryWolf
Copy link

Screenshare fully crashes vencord now, and the settings json for better mic has all of its profiles deleted, including the default ones it creates.

Also NTTS made a video about this plugin so discord might patch betterScreenshare

BetterMicrophone still works, and you can even get the configurator to open if you call the method directly. the only thing broken is the UI. I am planning to fix it soon but I cannot at the moment, as my neighbours house burned down and destroyed my PC peripherals. I can't afford a mouse at the moment after replacing other stuff so, I can't really do a whole lot to fix it yet

@qamwxy
Copy link

qamwxy commented Aug 5, 2024

yeah, now it crashes instantly.. hmmm

@qamwxy
Copy link

qamwxy commented Aug 5, 2024

Also NTTS made a video about this plugin so discord might patch betterScreenshare

Strange it works for him but not for anyone else

@qamwxy
Copy link

qamwxy commented Aug 5, 2024

If you still want to use the plugin, you can manually edit the settings json to change your mic and screenshare settings, as only the UI is broken

you can't, the button to stream instantly crashes your discord and right click doesn't open anything

@BlueberryWolf
Copy link

If you still want to use the plugin, you can manually edit the settings json to change your mic and screenshare settings, as only the UI is broken

you can't, the button to stream instantly crashes your discord and right click doesn't open anything

that comment was from 5 days ago bro, the crashes are more recent than that. BetterScreenshare is toast rn, but BetterMicrophone still works without the UI (you can actually get the microphone settings to open if you patch index.js to expose the function)

@Loukious
Copy link

Loukious commented Aug 6, 2024

I fixed the issues in my fork if anyone is interested.
You can install the fork by using my Vencord installer fork.
It's mostly for my personal use and provided as is and there's no guarantee that I'll push future updates when it breaks.
Enjoy!

@4kaytrey
Copy link

4kaytrey commented Aug 6, 2024

I fixed the issues in my fork if anyone is interested. You can install the fork by using my Vencord installer fork. It's mostly for my personal use and provided as is and there's no guarantee that I'll push future updates when it breaks. Enjoy!

I installed the fork which you made and it still seems to crash when you join calls, or itll just say RTC Connecting.

@Loukious
Copy link

Loukious commented Aug 6, 2024

I fixed the issues in my fork if anyone is interested. You can install the fork by using my Vencord installer fork. It's mostly for my personal use and provided as is and there's no guarantee that I'll push future updates when it breaks. Enjoy!

I installed the fork which you made and it still seems to crash when you join calls, or itll just say RTC Connecting.

Should probably check your plugin list. Mine is working perfectly.
image
image
image
image
Posting logs from console also help.

@qamwxy
Copy link

qamwxy commented Aug 6, 2024

I mean it works, sketchy af tho

and buggy

@Annabxlla
Copy link

I never posted a comment about it but I already took a look at the commits, and it looks fine.

@qamwxy
Copy link

qamwxy commented Aug 6, 2024

Issue resolved, setup your betterscreenshare settings first
(The fork client issue)

Finally, 240FPS stream and custom audio sorce

PS. Doesn't look like 240FPS, but 60

It doesn't change the fps, only the number that it shows, 99999999 fps doesn't crash anymore

@philhk
Copy link
Owner

philhk commented Aug 6, 2024

Unfortunately the framerate is currently broken and I'm unsure of the cause. If anyone discovers a fix please feel free to submit a pull request. However I would advise against spending too much time on this repository. If you are really motivated I recommend creating a whole new plugin from scratch using better practices than those used here.

@Annabxlla
Copy link

It does change what fps the other users see, and after testing with 1 fps and such it does seem to work, I don't have a way to test higher fps amounts as I'm not home and only have my phone and laptop with me.

@philhk
Copy link
Owner

philhk commented Aug 6, 2024

Yeah it's quite weird. You can set any custom frame rate between 1 and 30, but you can't go above that.

@BlueberryWolf
Copy link

BlueberryWolf commented Aug 6, 2024

Yeah it's quite weird. You can set any custom frame rate between 1 and 30, but you can't go above that.

it's because the client sets the requesting framerate. you can send a higher framerate stream but the client will not request frames at that rate. You would have to patch both the sending and receiving clients

@Tresillo2017
Copy link

I've tested and using the codec AV1 in the debug panel frame rate will go up to 120fps. Seems to be limited due to the codec for lower bandwidth.

@laythf06
Copy link

Has anyone gotten the HDR streaming to work. I can't figure it out.

@Killua81
Copy link

UI for better screenshare and microphone is broken....again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests