Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit link in preparation of it begin required #272

Merged
merged 1 commit into from
May 5, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Casks/app-zapper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class AppZapper < Cask
homepage 'http://www.appzapper.com/'
version 'latest'
no_checksum
link :app, 'AppZapper.app'
end
1 change: 1 addition & 0 deletions Casks/cyberduck.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class Cyberduck < Cask
homepage 'http://cyberduck.ch'
version '4.2.1'
sha1 '6f1e220830f324ba136b4301b12711f6037176c7'
link :app, 'Cyberduck.app'
end
1 change: 1 addition & 0 deletions Casks/daisy-disk.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class DaisyDisk < Cask
homepage 'http://www.daisydiskapp.com'
version '2.1.2'
sha1 '584eb479c41e2e73142fd69ce77bc57470d718de'
link :app, 'DaisyDisk.app'
end
1 change: 1 addition & 0 deletions Casks/filebot.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class Filebot < Cask
homepage 'http://www.filebot.net/'
version '3.6'
sha1 'ad492132226c0f6eb019a5dc62e59449cd5d98cd'
link :app, 'FileBot.app'
end
6 changes: 6 additions & 0 deletions Casks/menu-meters.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,10 @@ class MenuMeters < Cask
homepage 'http://www.ragingmenace.com/software/menumeters/'
version 'latest'
no_checksum
link :app, 'MenuMeters Installer.app'

def caveats; <<-EOS.undent
You need to run MenuMeters Installer.app to actually install MenuMeters
EOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nicely done. @phinze, @vitorgalvao could we do something like that for .pkgs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely like this. Together with your link :installer idea, and letting homebrew‐cask take care of the warnings, I think it’s a very acceptable solution.

There’s still the issue, like @phinze mentions on #14, of the installation not being contained within the Caskroom, but I think that is fine as long as it’s explicit in the warning.

There’s also no reason why the installation couldn’t be automatically started (even calling open would suffice), if the user asks for it. There are already casks that download .dmg files with agreements that show an “Are you sure? Y/N” prompt, so “why not”?

end
end
1 change: 1 addition & 0 deletions Casks/name-changer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class NameChanger < Cask
homepage 'http://www.mrrsoftware.com/MRRSoftware/NameChanger.html'
version '2.3.3'
sha1 'b9af8add259a0055a3748aeddfd56984a82cb6f2'
link :app, 'NameChanger.app'
end
1 change: 1 addition & 0 deletions Casks/please-sleep.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class PleaseSleep < Cask
homepage 'http://www.dragonone.com/products/macosx/pleasesleep/'
version 'latest'
no_checksum
link :app, 'PleaseSleep.app'
end
1 change: 1 addition & 0 deletions Casks/the-unarchiver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class TheUnarchiver < Cask
homepage 'http://unarchiver.c3.cx/'
version '3.7'
sha1 'da29b9f591d299cf1f869b7c77aac38908748ad5'
link :app, 'The Unarchiver.app'
end
1 change: 1 addition & 0 deletions Casks/you-need-a-budget.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ class YouNeedABudget < Cask
homepage 'http://www.youneedabudget.com/'
version '4.1.553'
sha1 'bf10b82ecf741d4655ab864717e307eb1858e385'
link :app, 'YNAB 4.app'
end