Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to update Dart SDK version of sidekickDartRuntime #149

Open
Giuspepe opened this issue Dec 16, 2022 · 3 comments · Fixed by #176
Open

Add possibility to update Dart SDK version of sidekickDartRuntime #149

Giuspepe opened this issue Dec 16, 2022 · 3 comments · Fixed by #176
Labels
low_priority sidekick_core https://pub.dev/packages/sidekick_core

Comments

@Giuspepe
Copy link
Contributor

Giuspepe commented Dec 16, 2022

Currently the sidekickDartRuntime's Dart SDK version can only be updated by increasing the minimum version constraint in the sidekick CLI's pubspec.yaml and running the CLI's entrypoint. This is not very intuitive and unnecessarily coupled. So we should add another way to update the sidekickDartRuntime's Dart SDK version.

We could add it to the sidekick update command, e.g. like this: sidekick update <{cli (default), dart}> [{<version>, latest}]

sidekick update cli or sidekick update to update the sidekick CLI (current implementation of the command)

sidekick update dart to update sidekickDartRuntime (new)

@Giuspepe Giuspepe added the sidekick_core https://pub.dev/packages/sidekick_core label Dec 16, 2022
@passsy
Copy link
Contributor

passsy commented Dec 17, 2022

I'd make it a separate command <cli> sidekick upgrade-embedded-sdk

@passsy
Copy link
Contributor

passsy commented Jan 10, 2023

Updating the embedded dart sdk is now possible with <cli> sidekick update.

@Giuspepe Please update the error message

// TODO update instructions when https://github.com/phntmxyz/sidekick/issues/149 is resolved

@Giuspepe
Copy link
Contributor Author

Updated the error message in #176

I guess we can close this issue then for now.

In the future it would still be nice to have a separate upgrade-embedded-sdk command and to save the embedded sdk version in the pubspec in the sidekick block instead of parsing it from environment: sdk: ..., i.e.

sidekick:
  cli_version: 0.13.1
  embedded_sdk_version: x.y.z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low_priority sidekick_core https://pub.dev/packages/sidekick_core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants