Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esbuild 0.16.0 changed registry locations #55

Closed
sldblog opened this issue Dec 9, 2022 · 2 comments
Closed

esbuild 0.16.0 changed registry locations #55

sldblog opened this issue Dec 9, 2022 · 2 comments

Comments

@sldblog
Copy link

sldblog commented Dec 9, 2022 •
edited
Loading

👋 Hello

Esbuild 0.16 changed the locations from

Relevant code:

esbuild/lib/esbuild.ex

Lines 207 to 208 in ac400e7

name = "esbuild-#{target()}"
url = "https://registry.npmjs.org/#{name}/-/#{name}-#{version}.tgz"

Is it okay to raise a PR to permanently change this location and bump the @latest_version to 0.16.3?
@josevalim
Copy link
Member

Please see #52 and #53. :)

@sldblog
Copy link
Author

sldblog commented Dec 9, 2022 •
edited
Loading

Ah, sorry for the overhead. I didn't see those. 🤦 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josevalim @sldblog