Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RpcClient has no reset functionality #458

Closed
tiborb opened this issue Aug 2, 2017 · 2 comments
Closed

RpcClient has no reset functionality #458

tiborb opened this issue Aug 2, 2017 · 2 comments

Comments

@tiborb
Copy link
Collaborator

tiborb commented Aug 2, 2017

The RpcClient needs a reset functionality to recover from missing server replies or other amqp expections.

In the following scenario the client will not return the result for the second call.

Solution: Add a reset function to manually recover from failed RPC calls and use the client again.

RpcClient:php

public function reset()
    {
        $this->replies = array();
        $this->requests = 0;
    }

Note that in Symfony the client service is declared once and getting a new instance is not possible by practical means.

@tiborb tiborb closed this as completed Aug 2, 2017
@tiborb tiborb reopened this Aug 2, 2017
@tiborb tiborb changed the title RpcClient needs reset functionality RpcClient has no reset functionality Aug 2, 2017
@tiborb tiborb self-assigned this Aug 2, 2017
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue was closed because it has been stalled for 10 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant