From e4fe49c2a317b2e0067b1fb642d18d6153718aba Mon Sep 17 00:00:00 2001
From: Konstantin Babushkin <koka@idwrx.com>
Date: Tue, 30 Jan 2024 10:19:47 +0100
Subject: [PATCH] final fixes

---
 doc/services/object-store/v1/index.rst     | 5 +++++
 samples/ObjectStore/v1/account/read.php    | 2 ++
 samples/ObjectStore/v1/containers/read.php | 3 ++-
 tests/sample/Networking/v2/NetworkTest.php | 2 +-
 tests/sample/Networking/v2/PortTest.php    | 5 +----
 tests/sample/Networking/v2/SubnetTest.php  | 4 ++--
 6 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/doc/services/object-store/v1/index.rst b/doc/services/object-store/v1/index.rst
index 83e52e19..5d699059 100644
--- a/doc/services/object-store/v1/index.rst
+++ b/doc/services/object-store/v1/index.rst
@@ -1,6 +1,11 @@
 Object Store v1
 ===============
 
+Object store (Swift) API Version 1. Swift is a highly available, distributed, eventually consistent object/blob store.
+Organizations can use Swift to store lots of data efficiently, safely, and cheaply.
+
+.. osdoc:: https://docs.openstack.org/api-ref/object-store/
+
 .. toctree::
     :maxdepth: 3
 
diff --git a/samples/ObjectStore/v1/account/read.php b/samples/ObjectStore/v1/account/read.php
index c96d92ea..82490797 100644
--- a/samples/ObjectStore/v1/account/read.php
+++ b/samples/ObjectStore/v1/account/read.php
@@ -13,3 +13,5 @@
 
 $service = $openstack->objectStoreV1();
 $account = $service->getAccount();
+
+$account->retrieve();
\ No newline at end of file
diff --git a/samples/ObjectStore/v1/containers/read.php b/samples/ObjectStore/v1/containers/read.php
index 685c82db..4f7b4206 100644
--- a/samples/ObjectStore/v1/containers/read.php
+++ b/samples/ObjectStore/v1/containers/read.php
@@ -13,4 +13,5 @@
 
 $service = $openstack->objectStoreV1();
 $container = $service->getContainer('{containerName}');
-$container->retrieve();
+
+$container->retrieve();
\ No newline at end of file
diff --git a/tests/sample/Networking/v2/NetworkTest.php b/tests/sample/Networking/v2/NetworkTest.php
index 1151eae9..df6a6532 100644
--- a/tests/sample/Networking/v2/NetworkTest.php
+++ b/tests/sample/Networking/v2/NetworkTest.php
@@ -53,7 +53,7 @@ public function testUpdate(Network $createdNetwork)
     /**
      * @depends testCreate
      */
-    public function testRetrieve(Network $createdNetwork)
+    public function testRead(Network $createdNetwork)
     {
         /** @var \OpenStack\Networking\v2\Models\Network $network */
         require_once $this->sampleFile('networks/read.php', ['{networkId}' => $createdNetwork->id]);
diff --git a/tests/sample/Networking/v2/PortTest.php b/tests/sample/Networking/v2/PortTest.php
index 1c31920f..05e08b5f 100644
--- a/tests/sample/Networking/v2/PortTest.php
+++ b/tests/sample/Networking/v2/PortTest.php
@@ -97,7 +97,7 @@ public function testList(Port $createdPort)
     /**
      * @depends testCreate
      */
-    public function testGet(Port $createdPort)
+    public function testRead(Port $createdPort)
     {
         /** @var $port \OpenStack\Networking\v2\Models\Port */
         require_once $this->sampleFile(
@@ -108,9 +108,6 @@ public function testGet(Port $createdPort)
 
         $this->assertInstanceOf(Port::class, $port);
         $this->assertNotEmpty($port->id);
-        $this->assertEmpty($port->name);
-
-        $port->retrieve();
         $this->assertNotEmpty($port->name);
     }
 
diff --git a/tests/sample/Networking/v2/SubnetTest.php b/tests/sample/Networking/v2/SubnetTest.php
index 05b55b82..0beb40f7 100644
--- a/tests/sample/Networking/v2/SubnetTest.php
+++ b/tests/sample/Networking/v2/SubnetTest.php
@@ -100,10 +100,10 @@ public function testUpdate(Subnet $createdSubnet)
     /**
      * @depends testCreate
      */
-    public function testRetrieve(Subnet $createdSubnet)
+    public function testRead(Subnet $createdSubnet)
     {
         /** @var $subnet \OpenStack\Networking\v2\Models\Subnet */
-        require_once $this->sampleFile('subnets/get.php', ['{subnetId}' => $createdSubnet->id]);
+        require_once $this->sampleFile('subnets/read.php', ['{subnetId}' => $createdSubnet->id]);
 
         $this->assertInstanceOf(Subnet::class, $subnet);
         $this->assertEquals($subnet->id, $subnet->id);