Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated locked dependencies need updating #25

Open
jacobcassidy opened this issue Aug 8, 2024 · 4 comments
Open

Outdated locked dependencies need updating #25

jacobcassidy opened this issue Aug 8, 2024 · 4 comments

Comments

@jacobcassidy
Copy link

jacobcassidy commented Aug 8, 2024

The following dependencies have new major versions available (^5.0 and ^7.0 respectively), but they cannot be updated because they're locked by this package.

"require": {
      "nikic/php-parser": "^4.10",
      "symfony/console": "^5.1 || ^6.0",
      "symfony/filesystem": "^5.0 || ^6.0",
      "symfony/finder": "^5.0 || ^6.0"
  },
@szepeviktor
Copy link
Member

szepeviktor commented Aug 8, 2024

Hello @jacobcassidy 👋🏻
I' had to fork this generator because the original has not merged PR-s.
I run it on PHP 7.4, others on PHP 8.*.

What constraints do you suggest?

@jacobcassidy
Copy link
Author

I use PHP 8.x, but keeping compatibility with versions back to 7.4 makes sense.

Will nikic/php-parser version 5.x and symfony component versions 7.x be compatible with PHP 7.4?

@szepeviktor
Copy link
Member

Will nikic/php-parser version 5.x

Documentation for version 5.x (current; for running on PHP >= 7.4; for parsing PHP 7.0 to PHP 8.3, with limited support for parsing PHP 5.x).

symfony component versions 7.x

Requires: PHP 8.2.0 or higher

@jacobcassidy
Copy link
Author

Looks like nikic/php-parser can be safely updated if the minimum PHP version supported will be 7.4. The Symfony updates may need to wait until 7.4 support is dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants