From 73c4fa0ea45d66e73128a12db213f6bc1831f89b Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 8 Nov 2024 19:36:14 +0100 Subject: [PATCH] ext/soap: fix `make check` being invoked in `ext/soap` On NixOS we run `make` & `make check` inside `ext/soap` which broke the test like this: 001+ Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing WSDL: Couldn't load from 'ext/soap/tests/gh15711.wsdl' : failed to load "ext/soap/tests/gh15711.wsdl": No such file or directory 002+ in /build/php-8.3.13/ext/soap/tests/gh15711.php:29 003+ Stack trace: 004+ #0 /build/php-8.3.13/ext/soap/tests/gh15711.php(29): SoapClient->__construct('ext/soap/tests/...', Array) 005+ #1 {main} 006+ thrown in /build/php-8.3.13/ext/soap/tests/gh15711.php on line 29 Fix is to make the path dependant on `__DIR__` as it's the case in other testcases including WSDLs. Closes GH-16733. --- NEWS | 3 +++ ext/soap/tests/gh15711.phpt | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8f3da809a180b..89c461bccdff9 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,9 @@ PHP NEWS - PDO: . Fixed memory leak of `setFetchMode()`. (SakiTakamachi) +- SOAP: + . Fix make check being invoked in ext/soap. (Ma27) + 07 Nov 2024, PHP 8.3.14RC1 - Cli: diff --git a/ext/soap/tests/gh15711.phpt b/ext/soap/tests/gh15711.phpt index a49ff280fee59..b72251cc6f95b 100644 --- a/ext/soap/tests/gh15711.phpt +++ b/ext/soap/tests/gh15711.phpt @@ -33,7 +33,7 @@ class TestSoapClient extends SoapClient { } } -$client = new TestSoapClient('ext/soap/tests/gh15711.wsdl', ['classmap' => ['book' => 'book']]); +$client = new TestSoapClient(__DIR__ . '/gh15711.wsdl', ['classmap' => ['book' => 'book']]); echo "--- Test with backed enum ---\n";