ReflectionParameter::__toString mangles special characters in strings

[nicolas-grekas]

Description

Issue demoed at https://3v4l.org/bMiN9#v8.1.10

The following code:

function f($b = ["\n", new \stdClass])
{
}

var_dump((string) (new ReflectionFunction("f"))->getParameters()[0]);

function g($b = ["\n"])
{
}

var_dump((string) (new ReflectionFunction('g'))->getParameters()[0]);

Resulted in this output:

string(55) "Parameter #0 [ <optional> $b = ['
', new \stdClass()] ]"
string(39) "Parameter #0 [ <optional> $b = ['\n'] ]"

But I expected this output instead:

string(55) "Parameter #0 [ <optional> $b = ['
', new \stdClass()] ]"
string(39) "Parameter #0 [ <optional> $b = ['
'] ]"

PHP Version

PHP 8.1+

Operating System

No response

[malarzm]

Not sure if feasible or not so just throwing ideas: preserving " in this case would also be fine (but probably could have other side effects too)

[nicolas-grekas]

Using double quotes would work, provided we also escape dollar signs.

[nicolas-grekas]

I'm closing here because I had a look at smart_str_append_escaped and the situation is quite manageable. It's easy to write code around the way PHP escapes default values. Also because changing this way might break existing code.

[stof]

@nicolas-grekas do you intend to submit the fix to doctrine/common then ?

[nicolas-grekas]

See doctrine/common#988 (comment) yes