[5.0.0-dev] codemirror hints

[williamdes]

Steps to reproduce

1. Create 1 table, min 1 column
2. Go to "SQL" in your table
3. Type the name of the columns after WHERE

Expected behaviour

Show type hint
https://demo.phpmyadmin.net/QA_4_8/index.php?db=world&table=City&target=tbl_sql.php&server=1

Actual behaviour

Shows [object object]
https://demo.phpmyadmin.net/master-config/tbl_sql.php?db=world&table=City&server=1

Browser

Google chrome : Version 67.0.3396.99 (Build officiel) (64 bits)

[aroralakshya]

This also happens in the console.

[williamdes]

Git bisect found that 393204c is the bad commit

[williamdes]

This is the bad change

diff --git a/js/vendor/codemirror/addon/hint/sql-hint.js b/js/vendor/codemirror/addon/hint/sql-hint.js
index 9601f14e0e..e3017fb313 100644
--- a/js/vendor/codemirror/addon/hint/sql-hint.js
+++ b/js/vendor/codemirror/addon/hint/sql-hint.js
@@ -275,7 +275,7 @@
     if (search.charAt(0) == "." || search.charAt(0) == identifierQuote) {
       start = nameCompletion(cur, token, result, editor);
     } else {
-      addMatches(result, search, defaultTable, function(w) {return {text:w, className: "CodeMirror-hint-table CodeMirror-hint-default-table"};});
+      addMatches(result, search, defaultTable, function(w) {return w;});
       addMatches(result, search, tables, function(w) {return w;});
       if (!disableKeywords)
         addMatches(result, search, keywords, function(w) {return w.toUpperCase();});

[williamdes]

See: codemirror/codemirror5@6041c22

See: codemirror/codemirror5#5348

[williamdes]

Made PR codemirror/codemirror5#5819