Don't double free the cache key

Addresses #1591
phpredis · Jul 17, 2019 · cb5d6b9 · yatsukhnenko · Jul 17, 2019 · cb5d6b9
1 parent 148bf37
commit cb5d6b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cluster_library.c b/cluster_library.c
@@ -892,8 +892,8 @@ cluster_free(redisCluster *c, int free_ctx)
     if (c->cache_key) {
         if (c->redirections) {
             zend_hash_del(&EG(persistent_list), c->cache_key);
+            c->cache_key = NULL;
         }
-        zend_string_release(c->cache_key);
     }
 
     /* Free structure itself */

diff --git a/redis.c b/redis.c
@@ -559,8 +559,10 @@ free_reply_callbacks(RedisSock *redis_sock)
 
 /* Passthru for destroying cluster cache */
 static void cluster_cache_dtor(zend_resource *rsrc) {
-    redisCachedCluster *rcc = (redisCachedCluster*)rsrc->ptr;
-    cluster_cache_free(rcc);
+    if (rsrc->ptr) {
+        redisCachedCluster *rcc = (redisCachedCluster*)rsrc->ptr;
+        cluster_cache_free(rcc);
+    }
 }
 
 void