Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow offset access on string #218

Open
mvorisek opened this issue Jun 29, 2023 · 0 comments
Open

Disallow offset access on string #218

mvorisek opened this issue Jun 29, 2023 · 0 comments

Comments

@mvorisek
Copy link

I propose to add, to strict rules, a rule to reject string offset access like:

$str[$index];
$str[5];

in favor of

substring($str, $index, 1)
substring($str, 5, 1)

The main motivation is to detect wrongly declared types. Currently when $var is declared wrongly as string instead of string[], it is undetected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant