From 5da68f7eb15e3cc8cd77743eaf1ae4b0a390df68 Mon Sep 17 00:00:00 2001 From: Kyle Willmon Date: Mon, 2 Oct 2023 10:45:38 -0500 Subject: [PATCH 1/2] Fix issues with cargo-update workflow This patch addresses many little issues: - The backtick (`) character was being interpreted as shell expansion in the `git commit` command - The `noreply` email for `phylum-bot` did not include the user ID - This repository does not use Conventional Commits, so the `build:` prefix was unnecessary --- .github/workflows/cargo-update.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cargo-update.yml b/.github/workflows/cargo-update.yml index 85f5a05cd..1df5fc2a3 100644 --- a/.github/workflows/cargo-update.yml +++ b/.github/workflows/cargo-update.yml @@ -22,8 +22,8 @@ jobs: continue-on-error: true run: | git config user.name 'Phylum Bot' - git config user.email 'phylum-bot@users.noreply.github.com' - git commit -a -m "build: Bump `Cargo.lock` dependencies" + git config user.email '69485888+phylum-bot@users.noreply.github.com' + git commit -a -m "Bump dependencies" git push --force origin HEAD:auto-cargo-update - name: Create Pull Request @@ -37,6 +37,6 @@ jobs: repo: context.repo.repo, head: "auto-cargo-update", base: context.ref, - title: "build: Bump `Cargo.lock` dependencies", - body: "Bump dependencies in `Cargo.lock` for all SemVer-compatible updates.", + title: "Bump dependencies", + body: "Bump dependencies for all SemVer-compatible updates.", }); From 41f250698063762fc35ff19bdadcb8e13328c6b8 Mon Sep 17 00:00:00 2001 From: Kyle Willmon Date: Mon, 2 Oct 2023 11:26:37 -0500 Subject: [PATCH 2/2] Use "phylum-bot" for committer name Co-authored-by: Charles Coggins --- .github/workflows/cargo-update.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cargo-update.yml b/.github/workflows/cargo-update.yml index 1df5fc2a3..6edaf338f 100644 --- a/.github/workflows/cargo-update.yml +++ b/.github/workflows/cargo-update.yml @@ -21,7 +21,7 @@ jobs: id: commit continue-on-error: true run: | - git config user.name 'Phylum Bot' + git config user.name 'phylum-bot' git config user.email '69485888+phylum-bot@users.noreply.github.com' git commit -a -m "Bump dependencies" git push --force origin HEAD:auto-cargo-update