Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1118 Encode strings as JSON in where clauses #1119

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

1118 Encode strings as JSON in where clauses #1119

wants to merge 4 commits into from

Conversation

dantownsend
Copy link
Member

Resolves #1118

@dantownsend dantownsend added the bug Something isn't working label Oct 25, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.24%. Comparing base (db57d6e) to head (15404b4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
piccolo/query/operators/json.py 80.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1119      +/-   ##
==========================================
- Coverage   88.42%   86.24%   -2.18%     
==========================================
  Files         117      117              
  Lines        8653     8659       +6     
==========================================
- Hits         7651     7468     -183     
- Misses       1002     1191     +189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Bugs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encode strings as JSON in where clauses
2 participants
@dantownsend @codecov-commenter