Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Try out a different MarkDown provider for the HTML output format #269

Closed
3 tasks
dirkrombauts opened this issue Jan 22, 2016 · 7 comments
Closed
3 tasks

Comments

@dirkrombauts
Copy link
Member

Try out Strike.Jint.Merged as the MarkDown provider, so that we can optionally enable GitHub Flavored Markdown later.

  • Add it to the code.
  • Make sure the unit tests are still passing
  • Generate sample outputs for Html, and compare them to the sample output on the pickles website.
@dirkrombauts
Copy link
Member Author

@dstj would you have time to take a stab at this?

@dirkrombauts dirkrombauts changed the title Spike: Try out a different MarkDown provider Spike: Try out a different MarkDown provider for the HTML output format Jan 22, 2016
@dstj
Copy link

dstj commented Jan 22, 2016

Hi Dirk, it won't be possible in the next few days/weeks,but I'll try to see if I can make up some time to try it out in a consistent manner. I'll like to avoid having my own separate custom fork for that...

@dirkrombauts
Copy link
Member Author

@dstj I'm playing around with this but I'm running into problems. Did you ever use Strike/markdownify in the static HTML version or only in the dynamic html version?

It works for me in the dynamic html version but in the static html version my own code is unhappy about <img> elements not being selfclosed.

@dstj
Copy link

dstj commented Mar 18, 2016

@dirkrombauts, I am unsure I understand your question, I don't recall seeing a dynamic or static option. My usage was very simplistic. I used it to transform Markdown file to HTML and the only code I need was:

public class MarkdownifyProvider : IMarkdownProvider
    {
        private readonly Markdownify markdownify;

        public MarkdownifyProvider()
        {
            this.markdownify = new Markdownify();
        }

        public string Transform(string text)
        {
            var transform = markdownify.Transform(text);
            transform = transform.Replace("&nbsp;", string.Empty);
            return transform;
        }
    }

@dirkrombauts
Copy link
Member Author

@dstj no problem, I found the solution for my problem. In fact there was no problem in Markdownify but rather in its documentation.

@dirkrombauts
Copy link
Member Author

Released as an experimental feature in version 2.5.0.

@dirkrombauts
Copy link
Member Author

It's been an amazing time for me to work on Pickles. Now it's finally time for me to lay down the mantle and move on. I am leaving Pickles completely.

I am closing this issue, so that the next maintainer of this repository can start from a clean slate.

Do you want to take over active development and maintenance at Pickles? Contact me directly at dirk dot rombauts at picklesdoc dot com. I will hand over everything Pickles-related to you. This email address will remain active until 11 December 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants