Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHTML uses the Feature's description for the Background #74

Closed
mcclade opened this issue Oct 30, 2013 · 5 comments
Closed

DHTML uses the Feature's description for the Background #74

mcclade opened this issue Oct 30, 2013 · 5 comments
Milestone

Comments

@mcclade
Copy link

mcclade commented Oct 30, 2013

When the following Gherkin is output as DHTML the Background uses the feature's description.

Feature: PBI46902 - Save wind forecasts to database
    As a Pickles user
    When I give a description in my background
    I want the background to use that description, not this text

Background:
    This text describes my background

Will produce HTML similar to:

<div class="scenario">
  <h4>Background:</h4>
  <div data-bind="html: renderMarkdownBlock(Description)" class="description">
      <p>As a Pickles user
    When I give a description in my background
    I want the background to use that description, not this text</p>
  </div>
....
</div>

It should produce something similar to this:

<div class="scenario">
  <h4>Background:</h4>
  <div data-bind="html: renderMarkdownBlock(Background.Description)" class="description">
      <p>This text describes my background</p>
  </div>
....
</div>
@dirkrombauts
Copy link
Member

resolved by #76

@dirkrombauts
Copy link
Member

Was reported as not fixed on the google newsgroup.

@dirkrombauts dirkrombauts reopened this Dec 3, 2013
@mcclade
Copy link
Author

mcclade commented Dec 3, 2013

Looks like the changes made to fix this (SHA: 9f5ab80) were rolled back by a later change (SHA: 6d9f899).

Should I make the changes again?

@dirkrombauts
Copy link
Member

Yes, please. And sorry about the mixup ...

@dirkrombauts
Copy link
Member

Hi,

@mcclade how are you? Any idea when you will be able to reapply the changes and send a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants