Javascript Split function seems not work well

[t-sky]

Hi, Mr. Mattila,

Thank you for your module, it's very useful to me.
I found a case that does not match my wants.

This code reproduces the situation.

const named = require('yesql').pg;
const sql = "select 'C:\\work' as path";
console.log(`after=${JSON.stringify((named(sql)({})))}`);

I hoped this should be {"text": "select 'C:\work' as path","values":[]}.
But the result is:

after={"text":"select 'C:\work'\work as path","values":[]}

I guess this "work work" is caused by the spec of Split function of Javascript.

So I added split_reg function to String prototype, and now it works well.

diff --git a/node_modules/yesql/yesql.js b/node_modules/yesql/yesql.js
--- a/node_modules/yesql/yesql.js
+++ b/node_modules/yesql/yesql.js
@@ -41,18 +41,35 @@ const pg = (query, options = {}) => {
     const matchDoubleQuoted = /("[^"\\]*(\\.[^"\\]*)*")/
     const values = []
 
+    String.prototype.split_reg = function (reg) {
+      let ret = [];
+      let start = 0;
+      let str = this;
+      while (true) {
+        str = str.substring(start);
+        let r = reg.exec(str);
+        if (r == null) {
+          ret.push(str);
+          return ret;
+        }
+        ret.push(str.substring(0, r.index));
+        ret.push(str.substring(r.index, r.index + r[0].length));
+        start = r.index + r[0].length;
+      }
+    }
     const text = query
       // remove -- comments
       .replace(/--.*$/gm, '')
       // remove /* */ comments
       .replace(/\/\*(\*(?!\/)|[^*])*\*\//g, '')
-      .split(matchQuoted)
+      //.split(matchQuoted)
+      .split_reg(matchQuoted)
       .map(part => {
         if (!part || matchQuoted.test(part)) {
           return part
         } else {
           return part
-            .split(matchDoubleQuoted)
+            .split_reg(matchDoubleQuoted)
             .map(part => {
                 if (!part || matchDoubleQuoted.test(part)) {
                   return part

How do you think about this workaround? Or is there any better way to go?

Thanks.

[pihvi]

Thanks for the report and use case!

I changed the regexp: 2ca7e32
which seems to make this work. This is now released as version 6.0.0.

Does this work for you? Do you see some other problems happening because of this approach?

[t-sky]

Thanks a lot for your quick fix. It works well for my case.
But it seems that \'s in double quotes cause the same problem.
I did not notice that. Can you fix this?

const named = require('yesql').pg;
const sql = "select 'C:\\work' as \"path_with_\\_in_it\"";
const after=named(sql)({})
console.log(`after.text=${after.text}`);

I hope that output should be:
after.text=select 'C:\work' as "path_with_\_in_it"

but:
after.text=select 'C:\work' as "path_with_\_in_it"\_in_it

Thanks.

[pihvi]

Good catch, thank you!

Fixed the same way in release 6.1.0

Does this work for you? Do you see some other problems happening because of this approach?

[t-sky]

Now all is Ok! Thank you!