Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handlebars 4.1.0. #166

Closed
przemyslaw-glod opened this issue Jul 4, 2019 · 9 comments
Closed

Update handlebars 4.1.0. #166

przemyslaw-glod opened this issue Jul 4, 2019 · 9 comments

Comments

@przemyslaw-glod
Copy link

Handlebars.js before 4.1.0 has Remote Code Execution (RCE)
WS-2019-0103 (More information - handlebars-lang/handlebars.js@edc6220)
Vulnerable versions: < 4.1.0
Patched version: 4.1.0

@dougwilson
Copy link
Contributor

dougwilson commented Jul 4, 2019

That version range is incomplete. The fix was also ported to the 4.0.x line as the version 4.0.13.

That link is to the following commit for 4.1.0 release: handlebars-lang/handlebars.js@edc6220

Here is the same commit contents that were applied as part of the 4.0.13 release: handlebars-lang/handlebars.js@7372d4e

@dougwilson
Copy link
Contributor

If it helps, this is the announcement made by the module on that particular issue, which shows the fixed versions: handlebars-lang/handlebars.js#1495

@przemyslaw-glod
Copy link
Author

great! thanks for answering, I missed that info

@dougwilson
Copy link
Contributor

Trying to consolidate the information around this: so WS-2019-0103 seems to be coming though as a GitHub security alert on repos. I contacted GitHub regarding the inaccurate version range information in the alert. They have responded back saying they are looking into it.

@dougwilson
Copy link
Contributor

I've been emailing GitHub every business day and so far still no updates on the incorrect alert they have.

@jrichardsz
Copy link

July 14, 2019

Github continues with this warning!!!

@dougwilson
Copy link
Contributor

Email Github about this through their contact form as well. Maybe the more people who contact them about this, they may actually fix the version range on their alert. Just email the contents of the first to comments here or a link to here.

I have sent numerous emails so far and got nothing but the automated response back.

@laserlemon
Copy link

👋 I apologize for the missed communication here! I'm on the GitHub team that's responsible for vulnerability alerting. I'm working to correct these inaccuracies here. Thank you!

@dougwilson
Copy link
Contributor

Hi @jrichardsz and others, the warning should no longer be showing up on your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants