Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE missing from distfile #98

Closed
0-wiz-0 opened this issue Aug 18, 2014 · 20 comments
Closed

LICENSE missing from distfile #98

0-wiz-0 opened this issue Aug 18, 2014 · 20 comments

Comments

@0-wiz-0
Copy link
Contributor

0-wiz-0 commented Aug 18, 2014

setup.py contains:

    :copyright: (c) 2014 Markus Unterwaditzer & contributors
    :license: MIT, see LICENSE for more details.

but the LICENSE file is not distributed (at least it's missing in vdirsyncer-0.2.3.tar.gz).

@geier
Copy link
Member

geier commented Aug 18, 2014

I have a feeling that a pkgsrc port is coming... :)

Quoting Markus Unterwaditzer (2014-08-18 12:35:36)

Closed #98 via 4af6da4.


Reply to this email directly or view it on GitHub:
#98 (comment)

@untitaker
Copy link
Member

@geier I looked up pkgsrc just now... what do you mean? Is somebody going to package vdirsyncer for another distro?

@untitaker
Copy link
Member

I just released a new version (0.2.4). Wanted to do that anyway because there's a fix for Radicale in there too.

@geier
Copy link
Member

geier commented Aug 18, 2014

@0-wiz-0 does the pkgsrc ports for pycarddav and vdirsyncer, so I
suspect he is making a port for vdirsyncer as well

Quoting Markus Unterwaditzer (2014-08-18 12:44:29)

@geier I looked up pkgsrc just now... what do you mean? Is somebody going to package vdirsyncer for another distro?


Reply to this email directly or view it on GitHub:
#98 (comment)

@untitaker
Copy link
Member

Got it, great!

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Aug 18, 2014

geier is a good guesser :)
I've packaged vdirsyncer for pkgsrc, see http://pkgsrc.se/time/py-vdirsyncer.
I've just updated it to 0.2.4, thanks for the quick fixes & release!

@untitaker
Copy link
Member

You're welcome!

Some questions though:

  • It seems to me that this is still listing 0.2.3 as the latest version.
  • How are PyPI deps handled with pkgsrc? Are they bundled in one package?

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Aug 18, 2014

Yes, the webpage is kept up-to-date by a cronjob, and I don't know when it runs. The package is at 0.2.4 already, though.

Dependencies are packaged separately, and should be listed on the page. If anything's missing, definitely let me know!

I have a question for you too: On my first run of vdirsyncer, I got a long backtrace ending in:

SSLError: [Errno 1] _ssl.c:514: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed

When I do

openssl s_client -host myhost -port myport -CAfile .vdirsyncer/cacert.crt

using the same certificate file that's configured for vdirsyncer:

[general]
# A folder where vdirsyncer can store some metadata about each pair.
status_path = ~/.vdirsyncer/status/
verify = /home/wiz/.vdirsyncer/cacert.crt
...

I get

    Verify return code: 0 (ok)

so openssl seems to be happy. Any ideas how to debug this?

@untitaker
Copy link
Member

I don't know which file is required for requests, and I know that this could use some documentation on my part. Seems like a PEM file is required, but I didn't try it.

@untitaker
Copy link
Member

Seems like you need to concat all (or some) certs of the trustchain: https://www.digicert.com/ssl-support/pem-ssl-creation.htm

@untitaker
Copy link
Member

Ugh, it seems like this is for client-side certificates. I don't use this myself...

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Aug 18, 2014

grepping the source code it seems you use requests, requests-toolbelt, and lxml. I've added these as dependencies.
I've tried concatenating all three certificates, no change.
"openssl s_client" is still happy when I pass it that file as input.

@untitaker
Copy link
Member

I read that part of the documentation wrongly. It seems like you're supposed to use a CA_BUNDLE path in there, but i don't know what that means.

@untitaker
Copy link
Member

I also use click and icalendar. setup.py contains a list.

@untitaker
Copy link
Member

Okay, I figured out how to do the certificate stuff:

2014-08-18-145552_538x155_scrot

This is the certificate info in firefox for https://unterwaditzer.net (click on lock-icon, "more information", "view certificate"). You need to export each certificate shown in the tree manually, and then concatenate the exported certs into one file.

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Aug 18, 2014

Ok, I tried that. Both in Top-Down and in Bottom-Up order, but I didn't get it working.

@untitaker
Copy link
Member

Is your certificate self-signed? Maybe it's still dependent on the global CA bundle.

@geier
Copy link
Member

geier commented Aug 18, 2014

Do you use pycarddav with the same server? Does it work there?

Quoting Markus Unterwaditzer (2014-08-18 15:05:02)

Is your certificate self-signed? Maybe it's still dependent on the real CA bundle.


Reply to this email directly or view it on GitHub:
#98 (comment)

@untitaker
Copy link
Member

Regardless of all this, the current state is not acceptable. See #99

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Aug 18, 2014

I use

insecure_ssl: 1

with pycarddav. It's a CACert-signed certificate (not self-signed).

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Aug 19, 2014
Version 0.2.4
=============

*released on 18 August 2014*

- Include workaround for collection discovery with latest version of Radicale.

- Include metadata files such as the changelog or license in source
  distribution, see issues `#97`_ and `#98`_.

.. _`#97`: pimutils/vdirsyncer#97
.. _`#98`: pimutils/vdirsyncer#98
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 11, 2014
Version 0.2.4
=============

*released on 18 August 2014*

- Include workaround for collection discovery with latest version of Radicale.

- Include metadata files such as the changelog or license in source
  distribution, see issues `#97`_ and `#98`_.

.. _`#97`: pimutils/vdirsyncer#97
.. _`#98`: pimutils/vdirsyncer#98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants