Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing docs for ACCOUNT_DEFAULT_HTTP_PROTOCOL #337

Closed
jonathan-s opened this issue Sep 27, 2020 · 0 comments · Fixed by #348
Closed

Missing docs for ACCOUNT_DEFAULT_HTTP_PROTOCOL #337

jonathan-s opened this issue Sep 27, 2020 · 0 comments · Fixed by #348
Labels
Bug

Comments

@jonathan-s
Copy link
Contributor

jonathan-s commented Sep 27, 2020 •
edited
Loading

Describe the bug
There is a setting ACCOUNT_DEFAULT_HTTP_PROTOCOL which is not documented. It defaults to http, in this day and age it should probably default to https?

Reproduce behavior
Check the documentation for settings and look for that setting. Can't be found. Also search for DEFAULT_HTTP_PROTOCOL in the codebase and you'll find it being used.

Expected behavior
It should be documented and https should possibly be used as a default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the default http protocol https jonathan-s/django-user-accounts
1 participant
@jonathan-s