Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Type checking error is not thrown #263

Closed
mqus opened this issue Feb 15, 2020 · 0 comments · Fixed by #268
Closed

Internal: Type checking error is not thrown #263

mqus opened this issue Feb 15, 2020 · 0 comments · Fixed by #268

Comments

@mqus
Copy link
Collaborator

mqus commented Feb 15, 2020

While improving the tests around #259, I noticed that the new Uint8List type was "not supported" yet as a parameter in dao functions, but no error occurred. After searching for the problem for about 15+ minutes, I finally noticed that the "throw" statement was missing in the following code 😆 .
https://github.com/vitusortner/floor/blob/5aa9486d4d909a105e9a21571e9fc1822bd2739a/floor_generator/lib/writer/query_method_writer.dart#L39-L44

But simply adding that throw is not enough, the isSupported getter itself also has to be altered because it does not accept List<>s of integers, strings or doubles for usage in IN clauses. This is maybe related to #155, as anyone implementing TypeConverters will probably have to take a look at that at some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant