Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate floor_generator's dependencies to null-safe versions #504

Closed
6 tasks done
vitusortner opened this issue Mar 8, 2021 · 2 comments · Fixed by #543
Closed
6 tasks done

Migrate floor_generator's dependencies to null-safe versions #504

vitusortner opened this issue Mar 8, 2021 · 2 comments · Fixed by #543
Labels
refactoring Improvement without changing functionality

Comments

@vitusortner
Copy link
Collaborator

vitusortner commented Mar 8, 2021

We have recently migrated the codebase to support null-safety (#462). We're now generating null-safe code but floor_generator's internal dependencies aren't exclusively null-safe.

Migrate the dependencies to their null-safe versions once available and make sure to not run tests with --no-sound-null-safety anymore (CI).

  • build
  • build_config
  • build_test
  • code_builder
  • dart_style
  • source_gen

Additionally, make sure to get rid of the mockito (5.0.2) dependency override, which was introduced to make floor work with source_gen 1.0.0. The tracking issue for mockito can be found here: dart-lang/mockito#373.

@vitusortner vitusortner added the refactoring Improvement without changing functionality label Mar 8, 2021
@rickydj
Copy link

rickydj commented Mar 17, 2021

Please, fix this as soon as possible, i cant build entities because i have problems with this as it cant be null safety, the system said: "Query method parameters have to be non-nullable. Define id as non-nullable."

@vitusortner
Copy link
Collaborator Author

Please, fix this as soon as possible, i cant build entities because i have problems with this as it cant be null safety, the system said: "Query method parameters have to be non-nullable. Define id as non-nullable."

We're tracking this problem in a separate issue #507.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improvement without changing functionality
Development

Successfully merging a pull request may close this issue.

2 participants