Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max-replicas documentation needs to be extended #5866

Closed
dveeden opened this issue Jun 25, 2021 · 2 comments
Closed

max-replicas documentation needs to be extended #5866

dveeden opened this issue Jun 25, 2021 · 2 comments
Assignees
@nolouch @disksing

Comments

@dveeden
Copy link
Contributor

dveeden commented Jun 25, 2021

The replication.max-replicas documentation on https://docs.pingcap.com/tidb/stable/pd-configuration-file#max-replicas should be extended with:

  • A more complete description about what this option does
  • If and how this can be changed online
  • Why one might want to change this setting

A link to a document that explains this would also be sufficient.
@disksing
Copy link
Contributor

Thanks for your suggestion. I'll improve it.

This was referenced Jul 14, 2021
Merged
Merged
@TomShawn
Copy link
Contributor

TomShawn commented Jul 15, 2021 •
edited
Loading

@dveeden PTAL this PR: #5984. Thanks~

@nolouch nolouch closed this as completed Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nolouch nolouch

@disksing disksing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dveeden @nolouch @disksing @TomShawn