Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify which mydumper to use #630

Closed
morgo opened this issue Sep 26, 2018 · 0 comments · Fixed by #644
Closed

Clarify which mydumper to use #630

morgo opened this issue Sep 26, 2018 · 0 comments · Fixed by #644
Assignees
@morgo
Labels
status/TODO This issue is in a to-do list and will be fixed later.

Comments

@morgo
Copy link
Contributor

morgo commented Sep 26, 2018

The manual currently includes a link to mydumper, but doesn't mention we have a fork of it as well:
https://pingcap.com/docs/op-guide/backup-restore/

The upstream mydumper is actually unsafe for TiDB. We have a PR request to fix it, and assuming it's merged we should update the advice to say the minimum version to use.

Or alternatively, we should point to our official mydumper
@morgo morgo added the status/TODO This issue is in a to-do list and will be fixed later. label Sep 26, 2018
@morgo morgo self-assigned this Sep 26, 2018
@morgo morgo mentioned this issue Oct 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgo morgo

Labels
status/TODO This issue is in a to-do list and will be fixed later.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

op-guide, tools: Recommend mydumper from enterprise tools
1 participant
@morgo