From 6d79e073cbaa93772c064b2e55ac2d103fbc4b34 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 2 Sep 2021 17:37:45 +0800 Subject: [PATCH 1/3] sql: fix the correctness problem about kill Signed-off-by: Weizhen Wang --- sql-statements/sql-statement-kill.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql-statements/sql-statement-kill.md b/sql-statements/sql-statement-kill.md index 99b153eb5483e..53acdf8e41d5d 100644 --- a/sql-statements/sql-statement-kill.md +++ b/sql-statements/sql-statement-kill.md @@ -36,7 +36,7 @@ Query OK, 0 rows affected (0.00 sec) * By design, `KILL` is not compatible with MySQL by default. This helps prevent against a case of a connection being terminated on the wrong TiDB server, because it is common to place multiple TiDB servers behind a load balancer. * DO NOT set [`compatible-kill-query = true`](/tidb-configuration-file.md#compatible-kill-query) in your configuration file UNLESS you are certain that clients will be always connected to the same TiDB node. This is because pressing ctrl+c in the default MySQL client opens a new connection in which `KILL` is executed. If there are proxies in between, the new connection might be routed to a different TiDB node, which possibly kills a different session. -* The `KILL TIDB` statement is a TiDB extension, which is a different syntax from the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. +* The `KILL TIDB` statement is a TiDB extension, which is the same function as the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. ## See also From d0c0ea24799372050fac4cebce6700cbfa8fbeb2 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Thu, 2 Sep 2021 18:21:27 +0800 Subject: [PATCH 2/3] Update sql-statements/sql-statement-kill.md Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> --- sql-statements/sql-statement-kill.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql-statements/sql-statement-kill.md b/sql-statements/sql-statement-kill.md index 53acdf8e41d5d..4e24f540c16e3 100644 --- a/sql-statements/sql-statement-kill.md +++ b/sql-statements/sql-statement-kill.md @@ -36,7 +36,7 @@ Query OK, 0 rows affected (0.00 sec) * By design, `KILL` is not compatible with MySQL by default. This helps prevent against a case of a connection being terminated on the wrong TiDB server, because it is common to place multiple TiDB servers behind a load balancer. * DO NOT set [`compatible-kill-query = true`](/tidb-configuration-file.md#compatible-kill-query) in your configuration file UNLESS you are certain that clients will be always connected to the same TiDB node. This is because pressing ctrl+c in the default MySQL client opens a new connection in which `KILL` is executed. If there are proxies in between, the new connection might be routed to a different TiDB node, which possibly kills a different session. -* The `KILL TIDB` statement is a TiDB extension, which is the same function as the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. +* The `KILL TIDB` statement is a TiDB extension, which is similar to the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. ## See also From 13cf2715850a1a2f1208539cdce94b23c8c320fe Mon Sep 17 00:00:00 2001 From: Enwei Date: Thu, 2 Sep 2021 12:39:12 +0200 Subject: [PATCH 3/3] Update sql-statements/sql-statement-kill.md --- sql-statements/sql-statement-kill.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql-statements/sql-statement-kill.md b/sql-statements/sql-statement-kill.md index 4e24f540c16e3..9396e4ab3946d 100644 --- a/sql-statements/sql-statement-kill.md +++ b/sql-statements/sql-statement-kill.md @@ -36,7 +36,7 @@ Query OK, 0 rows affected (0.00 sec) * By design, `KILL` is not compatible with MySQL by default. This helps prevent against a case of a connection being terminated on the wrong TiDB server, because it is common to place multiple TiDB servers behind a load balancer. * DO NOT set [`compatible-kill-query = true`](/tidb-configuration-file.md#compatible-kill-query) in your configuration file UNLESS you are certain that clients will be always connected to the same TiDB node. This is because pressing ctrl+c in the default MySQL client opens a new connection in which `KILL` is executed. If there are proxies in between, the new connection might be routed to a different TiDB node, which possibly kills a different session. -* The `KILL TIDB` statement is a TiDB extension, which is similar to the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. +* The `KILL TIDB` statement is a TiDB extension. The feature of this statement is similar to the MySQL `KILL [CONNECTION|QUERY]` command and the MySQL command-line ctrl+c feature. It is safe to use `KILL TIDB` on the same TiDB node. ## See also