You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
sql_mode is a global/session variable, it may changed easily. I think we can not truly tell what sql_mode is when the table created. so record the sql_mode for current snapshot is meaningless?
sql_mode take effect when dumpling read, not when table create.
dumpling would use all global variables as its session variables (if not configurated), and in dump process session variables are not changed by iteslf (and can't be changed from outside?). so I think it would represent dump file's context
Feature Request
Is your feature request related to a problem? Please describe:
mydumper's metadata has some not so good design, for example, write an empty
GTID:
when not enable GTID.and dumpling has diverged a little in #146 . so maybe we could record more context in metadata
Describe the feature you'd like:
SQL Mode (mainly ANSI_QUOTES) is needed to correctly parse dump files, so it should be written somewhere
for example
Describe alternatives you've considered:
currently DM will query SQL Mode from upstream, so it's OK not add this feature. But if user changes SQL Mode after dump it will fail.
and maybe dumpling could use a default context to dump SQLs.
Teachability, Documentation, Adoption, Optimization:
The text was updated successfully, but these errors were encountered: