Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation requires cmake, protoc, golang, perl... #354

Closed
4 tasks
Hoverbear opened this issue Feb 13, 2019 · 5 comments
Closed
4 tasks

Installation requires cmake, protoc, golang, perl... #354

Hoverbear opened this issue Feb 13, 2019 · 5 comments
Labels

Comments

@Hoverbear
Copy link
Contributor

Hoverbear commented Feb 13, 2019

Prior to #347 I do not think cmake, protoc, golang, perl were required to pull kvproto into a Rust dependency.

Having these extra dependencies is rather problematic. protoc in particular is not a commonly installed tool.

Resolving this issue would involve ensuring downstream dependencies can use kvproto without:

  • cmake
  • protoc
  • golang
  • perl

Labelling this as a bug as I think it's a regression. cc @nrc .

@Hoverbear Hoverbear added the bug label Feb 13, 2019
@nrc
Copy link
Contributor

nrc commented Feb 13, 2019

This is addressed in my WIP PR: #349 by making code generation opt-in and not done by default.

@Hoverbear
Copy link
Contributor Author

Thanks Nick! :)

@ice1000
Copy link
Contributor

ice1000 commented Feb 14, 2019

sed is also needed by the way.

@gregwebs
Copy link
Contributor

@nrc should this issue be closed now? We can open up a new one for further simplifying the build process.

@nrc
Copy link
Contributor

nrc commented Jan 21, 2021

Sure, I have no idea about the current build reqs, but this issue is out of date

@nrc nrc closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants