Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: make counter inc when operator finished rather than operator add (#2962) #2983

Merged
merged 4 commits into from
Sep 17, 2020
Merged

metrics: make counter inc when operator finished rather than operator add (#2962) #2983

merged 4 commits into from
Sep 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2962 to release-4.0

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

we statistic the operator when the operator added, it will be more helpful to statistic move-peer and move-leader when the operator finished

What is changed and how it works?

add additional counters

Check List

Tests

  • Unit test

Release note

  • improvement: make counter inc when operator finished rather than operator add

@ti-srebot ti-srebot mentioned this pull request Sep 17, 2020
Merged
@ti-srebot ti-srebot added component/metrics Metrics. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Sep 17, 2020
@ti-srebot ti-srebot added this to the v4.0.7 milestone Sep 17, 2020
@disksing
Copy link
Contributor

Please resolve conflicts. @lhy1024

@lhy1024
fix conflict
e09be41 
Signed-off-by: lhy1024 <[email protected]>
HunDunDM
HunDunDM approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 17, 2020
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2020
@lhy1024
lint
acb2b3a 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2974

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-integration-lightning-test

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-integration-compatibility-test

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-integration-lightning-test

1 similar comment
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-integration-lightning-test

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2974

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2974
  • 2974
  • 2974

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2974
  • 2974
  • 2974

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2974
  • 2974
  • 2974
  • 2974
  • 2974

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2974
  • 2974
  • 2974
  • 2974
  • 2974

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2974
  • 2974
  • 2974
  • 2974
  • 2974

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2983 into release-4.0 will increase coverage by 0.16%.
The diff coverage is 67.04%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2983      +/-   ##
===============================================
+ Coverage        77.16%   77.33%   +0.16%     
===============================================
  Files              204      209       +5     
  Lines            21940    22872     +932     
===============================================
+ Hits             16931    17688     +757     
- Misses            3724     3841     +117     
- Partials          1285     1343      +58
Impacted Files Coverage Δ
client/metrics.go 100.00% <ø> (ø)
pkg/apiutil/apiutil.go 67.34% <ø> (ø)
pkg/cache/cache.go 0.00% <ø> (ø)
pkg/cache/fifo.go 100.00% <ø> (ø)
pkg/cache/lru.go 80.35% <ø> (ø)
pkg/cache/two_queue.go 66.66% <ø> (ø)
pkg/codec/codec.go 78.57% <ø> (ø)
pkg/component/manager.go 81.01% <ø> (ø)
pkg/dashboard/adapter/redirector.go 94.23% <ø> (ø)
pkg/dashboard/keyvisual/input/core.go 33.33% <ø> (ø)
... and 208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abf45a...3c08d91. Read the comment docs.

@ti-srebot ti-srebot merged commit 5f4a863 into tikv:release-4.0 Sep 17, 2020
@disksing disksing deleted the release-4.0-14d559b1412b branch September 21, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HunDunDM HunDunDM HunDunDM approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees

@lhy1024 lhy1024

Labels
component/metrics Metrics. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v4.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @disksing @lhy1024 @HunDunDM