Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide way to set store labels for TiKV during initialization #2692

Closed
Yisaer opened this issue Jun 12, 2020 · 5 comments
Closed

Provide way to set store labels for TiKV during initialization #2692

Yisaer opened this issue Jun 12, 2020 · 5 comments
Labels
area/auto-scaling related to auto-scaling area/heterogeneous related to tidb/tikv heterogeneous groups enhancement New feature or request
Milestone

Comments

@Yisaer
Copy link
Contributor

Yisaer commented Jun 12, 2020

Feature Request

Is your feature request related to a problem? Please describe:

Sometimes we need TiKV Initialize with some store labels in order to schedule the data they need instead of setting labels by pd-api after tikv started.

Describe the feature you'd like:

TiKVSpec should provide a way to let users setting the initialization labels.

@Yisaer Yisaer added the enhancement New feature or request label Jun 12, 2020
@Yisaer
Copy link
Contributor Author

Yisaer commented Jun 12, 2020

@mahjonp Does this feature meet your requirement?

@mahjonp
Copy link
Contributor

mahjonp commented Jun 12, 2020

Cool. /cc @BusyJay @cosven

@cosven
Copy link

cosven commented Jun 12, 2020

My requirement is that different tikv pod can have different labels.

To my understanding, if we set labels in TiKVSpec, all tikv pods will have the same labels?

@Yisaer
Copy link
Contributor Author

Yisaer commented Jun 12, 2020

@cosven Your understanding is right. For your requirement, I think mixing the heterogeneous design and this feature might work.

@Yisaer Yisaer added area/auto-scaling related to auto-scaling area/heterogeneous related to tidb/tikv heterogeneous groups labels Jul 3, 2020
@Yisaer Yisaer added this to the v1.2.0 milestone Jul 3, 2020
@DanielZhangQD
Copy link
Contributor

We can set labels via config here and as @Yisaer has explained, when the heterogeneous deployment is supported, we can deploy TiKVs with different labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auto-scaling related to auto-scaling area/heterogeneous related to tidb/tikv heterogeneous groups enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants