Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data race detected #18526

Closed
XuHuaiyu opened this issue Jul 14, 2020 · 5 comments
Closed

data race detected #18526

XuHuaiyu opened this issue Jul 14, 2020 · 5 comments
Labels
component/test severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@XuHuaiyu
Copy link
Contributor 

[2020-07-14T02:16:00.902Z] ==================

[2020-07-14T02:16:00.902Z] WARNING: DATA RACE

[2020-07-14T02:16:00.903Z] Write at 0x00c0002ec308 by goroutine 60:

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/executor.ResetContextOfStmt()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/executor.go:1666 +0xe1d

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.(*session).ExecuteStmt()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1140 +0x1f1

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.(*session).Execute()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1081 +0x3ee

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.execRestrictedSQL()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:835 +0x15c

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.(*session).ExecRestrictedSQLWithContext()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:774 +0x25b

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.(*session).ExecRestrictedSQL()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:744 +0x92

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/statistics/handle.(*Handle).Update()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/handle.go:162 +0x1eb

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/domain.(*Domain).loadStatsWorker()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:1096 +0x571

[2020-07-14T02:16:00.903Z] 

[2020-07-14T02:16:00.903Z] Previous read at 0x00c0002ec308 by goroutine 139:

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startIndexWorker.func1()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:514 +0x477

[2020-07-14T02:16:00.903Z] 

[2020-07-14T02:16:00.903Z] Goroutine 60 (running) created at:

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/domain.(*Domain).UpdateTableStatsLoop()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:1041 +0x332

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.BootstrapSession()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1822 +0x4f3

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1181 +0x3d9

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1179 +0x3ac

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1177 +0x37f

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1175 +0x352

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1173 +0x325

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1171 +0x2f8

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1169 +0x2cb

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1167 +0x29e

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1165 +0x271

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1163 +0x244

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1161 +0x217

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.903Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1159 +0x1ea

[2020-07-14T02:16:00.903Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1157 +0x1bd

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1156 +0x190

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1155 +0x163

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1154 +0x136

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1152 +0x109

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1150 +0xdc

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.doDDLWorks()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:1148 +0x5b

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.bootstrap()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/bootstrap.go:310 +0x1a1

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.runInBootstrapSession()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1853 +0xe2

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/session.BootstrapSession()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1747 +0xb69

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/planner/cascades_test.newStoreWithBootstrap()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/planner/cascades/integration_test.go:40 +0xac

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/planner/cascades_test.(*testIntegrationSuite).SetUpSuite()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/planner/cascades/integration_test.go:46 +0x44

[2020-07-14T02:16:00.904Z]   runtime.call32()

[2020-07-14T02:16:00.904Z]       /usr/local/go/src/runtime/asm_amd64.s:539 +0x3a

[2020-07-14T02:16:00.904Z]   reflect.Value.Call()

[2020-07-14T02:16:00.904Z]       /usr/local/go/src/reflect/value.go:321 +0xd3

[2020-07-14T02:16:00.904Z]   github.com/pingcap/check.(*suiteRunner).runFixture.func1()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/[email protected]/check.go:799 +0x195

[2020-07-14T02:16:00.904Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/[email protected]/check.go:739 +0x113

[2020-07-14T02:16:00.904Z] 

[2020-07-14T02:16:00.904Z] Goroutine 139 (finished) created at:

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startIndexWorker()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:501 +0xbc8

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startWorkers()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:429 +0xcb

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Next()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:598 +0x421

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/executor.Next()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/executor.go:267 +0x16a

[2020-07-14T02:16:00.904Z]   github.com/pingcap/tidb/executor.(*projectionInputFetcher).run()

[2020-07-14T02:16:00.904Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/projection.go:369 +0x41c

[2020-07-14T02:16:00.904Z] ==================

[2020-07-14T02:16:00.904Z] Found 1 data race(s)

[2020-07-14T02:16:00.904Z] FAIL	github.com/pingcap/tidb/planner/cascades	6.588s
@XuHuaiyu XuHuaiyu added the type/bug The issue is confirmed as a bug. label Jul 14, 2020
@crazycs520
Copy link
Contributor

Is anyone investigating this?

@zimulala
Copy link
Contributor

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/42679/pipeline/

@zimulala zimulala mentioned this issue Jul 14, 2020
Merged
@crazycs520
Copy link
Contributor

I am investigating this UT now.

@crazycs520 crazycs520 mentioned this issue Jul 14, 2020
Closed
@crazycs520
Copy link
Contributor

#18541 This PR should avoid this race to make ci stable, but the root cause of the race has not been located...

@jebter jebter added the sig/sql-infra SIG: SQL Infra label Dec 7, 2021
@tiancaiamao
Copy link
Contributor

This issue has been there for quite a long time.
After #30822, I guess it's solved.
Close for now, if it still reproduce, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/test severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tiancaiamao @zimulala @jebter @XuHuaiyu @crazycs520 @sre-bot