Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lazy open union children #21441

Closed
lysu opened this issue Dec 2, 2020 · 2 comments · Fixed by #21561 or #24899
Closed

Support lazy open union children #21441

lysu opened this issue Dec 2, 2020 · 2 comments · Fixed by #21561 or #24899
Assignees
Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.

Comments

@lysu
Copy link
Contributor

lysu commented Dec 2, 2020

Development Task

In #19827, we support concurrency control for Union's children execution.

but Union executor still Init all children before execute Next

init children will cause sub-plan nodes's Init be called

combined with #14320, partition table will make the "buildCopTasks takes too much time" problem even worse.

so for a partition table with 128 partitions

select * from partition_table limit 1;

it will build all copTask in memory for each 128 partitions before send any request to tikv(and finally maybe only 1 request is useful)

@lysu lysu added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Dec 2, 2020
@SunRunAway SunRunAway assigned XuHuaiyu and unassigned SunRunAway Dec 3, 2020
@tiancaiamao
Copy link
Contributor

There is such an attempt some time ago #16815

@XuHuaiyu
Copy link
Contributor

reopen this issue cause the fix is reverted in #23276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment