Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary pessimistic rollback is sent on ErrKeyExists #23799

Closed
sticnarf opened this issue Apr 1, 2021 · 2 comments
Closed

Unnecessary pessimistic rollback is sent on ErrKeyExists #23799

sticnarf opened this issue Apr 1, 2021 · 2 comments
Labels
severity/minor sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@sticnarf
Copy link
Contributor

sticnarf commented Apr 1, 2021

Bug Report

1. Minimal reproduce step (Required)

It is a regression caused by #22976.

#22976 created a ErrKeyExists wrapper in store/tikv. Then, the type match at https://github.com/sticnarf/tidb/blob/375de3758c/store/tikv/txn.go#L472 was incorrect. Unnecessary pessimistic rollback may be sent if we receive ErrKeyExists.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@sticnarf
Copy link
Contributor Author

#23686 has fixed it on master.

@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

2 participants