IndexLookupJoin related case got data race

[guo-shaoge]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Found by CI unit-test

2. What did you expect to see? (Required)

Case runs ok.

3. What did you see instead (Required)

[2021-06-02T15:05:43.297Z] WARNING: DATA RACE
[2021-06-02T15:05:43.297Z] Write at 0x0000079c43a0 by goroutine 757:
[2021-06-02T15:05:43.297Z]   github.com/pingcap/tidb/executor_test.(*testSuite1).testAnalyzeIncremental.func1()
[2021-06-02T15:05:43.297Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/analyze_test.go:614 +0xa4
[2021-06-02T15:05:43.297Z]   github.com/pingcap/tidb/executor_test.(*testSuite1).testAnalyzeIncremental()
[2021-06-02T15:05:43.297Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/analyze_test.go:664 +0x200f
[2021-06-02T15:05:43.297Z]   github.com/pingcap/tidb/executor_test.(*testSuite1).TestAnalyzeIncremental()
[2021-06-02T15:05:43.297Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/analyze_test.go:581 +0x114
[2021-06-02T15:05:43.297Z]   runtime.call16()
[2021-06-02T15:05:43.298Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-06-02T15:05:43.298Z]   reflect.Value.Call()
[2021-06-02T15:05:43.298Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-06-02T15:05:43.298Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-06-02T15:05:43.298Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:850 +0xb3b
[2021-06-02T15:05:43.298Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-06-02T15:05:43.298Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:739 +0x11d
[2021-06-02T15:05:43.298Z] 
[2021-06-02T15:05:43.298Z] Previous read at 0x0000079c43a0 by goroutine 861:
[2021-06-02T15:05:43.298Z]   github.com/pingcap/tidb/statistics/handle.(*SessionStatsCollector).StoreQueryFeedback()
[2021-06-02T15:05:43.298Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/statistics/handle/update.go:181 +0x224
[2021-06-02T15:05:43.298Z]   github.com/pingcap/tidb/session.(*session).StoreQueryFeedback()
[2021-06-02T15:05:43.298Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:392 +0x4f9
[2021-06-02T15:05:43.298Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startIndexWorker.func1()
[2021-06-02T15:05:43.298Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:593 +0xaa4
[2021-06-02T15:05:43.298Z] 
[2021-06-02T15:05:43.298Z] Goroutine 757 (running) created at:
[2021-06-02T15:05:43.298Z]   github.com/pingcap/check.(*suiteRunner).forkCall()
[2021-06-02T15:05:43.298Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:734 +0x4cc
[2021-06-02T15:05:43.299Z]   github.com/pingcap/check.(*suiteRunner).forkTest()
[2021-06-02T15:05:43.299Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:832 +0x1c4
[2021-06-02T15:05:43.299Z]   github.com/pingcap/check.(*suiteRunner).doRun()
[2021-06-02T15:05:43.299Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:666 +0x144
[2021-06-02T15:05:43.299Z]   github.com/pingcap/check.(*suiteRunner).asyncRun.func1()
[2021-06-02T15:05:43.299Z]       /nfs/cache/mod/github.com/pingcap/[email protected]/check.go:650 +0x105
[2021-06-02T15:05:43.299Z] 
[2021-06-02T15:05:43.299Z] Goroutine 861 (finished) created at:
[2021-06-02T15:05:43.299Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startIndexWorker()
[2021-06-02T15:05:43.299Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:529 +0x504
[2021-06-02T15:05:43.299Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).startWorkers()
[2021-06-02T15:05:43.299Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:483 +0x84
[2021-06-02T15:05:43.299Z]   github.com/pingcap/tidb/executor.(*IndexLookUpExecutor).Next()
[2021-06-02T15:05:43.299Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/distsql.go:692 +0x646
[2021-06-02T15:05:43.299Z]   github.com/pingcap/tidb/executor.Next()
[2021-06-02T15:05:43.299Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/executor.go:286 +0x2a8
[2021-06-02T15:05:43.299Z]   github.com/pingcap/tidb/executor.(*outerWorker).buildTask()
[2021-06-02T15:05:43.299Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_join.go:402 +0x77d
[2021-06-02T15:05:43.299Z]   github.com/pingcap/tidb/executor.(*outerWorker).run()
[2021-06-02T15:05:43.299Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_join.go:346 +0x15d

4. What is your TiDB version? (Required)

master

[qw4990]

@time-and-fate Could you take a look at this~?

[time-and-fate]

Close it since it's a duplicate of #25013 and it has been fixed.

[ti-srebot]

Please edit this comment or add a new comment to complete the following information

Not a bug

1. Remove the 'type/bug' label
2. Add notes to indicate why it is not a bug

Duplicate bug

1. Add the 'type/duplicate' label
2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions