Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Metrics to Monitor PD API call exection time #29821

Closed
Tracked by #18030
morgo opened this issue Nov 16, 2021 · 1 comment · Fixed by #30062
Closed
Tracked by #18030

Add Metrics to Monitor PD API call exection time #29821

morgo opened this issue Nov 16, 2021 · 1 comment · Fixed by #30062
Assignees
@jyz0309

Comments

@morgo
Copy link
Contributor

morgo commented Nov 16, 2021 •
edited
Loading

This issue was reported by @AilinKid

We should support the ability to time PD API calls so that we can better investigate user reported issues with placement rule DDL. There might be some scenarios where PD API call time takes longer than expected.
@morgo morgo mentioned this issue Nov 16, 2021
Closed
@jyz0309
Copy link
Contributor

jyz0309 commented Nov 22, 2021

/assign
I think we can just time the requestPD(method, uri string, body io.Reader, res interface{}) error function, Is it?

@jyz0309 jyz0309 mentioned this issue Nov 23, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyz0309 jyz0309

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

store: Add metrics for pd api call time jyz0309/tidb
2 participants
@morgo @jyz0309