Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a MockConn to enable testing connections #30109

Closed
Tracked by #30108
djshow832 opened this issue Nov 24, 2021 · 0 comments · Fixed by #30119
Closed
Tracked by #30108

Add a MockConn to enable testing connections #30109

djshow832 opened this issue Nov 24, 2021 · 0 comments · Fixed by #30119
Assignees
@djshow832
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@djshow832
Copy link
Contributor

djshow832 commented Nov 24, 2021 •
edited
Loading

Currently, it's hard to add tests that involve connections outside of the server package. One example is testing the audit log. We need to mock a connection.
@djshow832 djshow832 mentioned this issue Nov 24, 2021
Open
3 tasks
@djshow832 djshow832 added the type/enhancement The issue or PR belongs to an enhancement. label Nov 24, 2021
@djshow832 djshow832 self-assigned this Nov 24, 2021
@djshow832 djshow832 mentioned this issue Nov 24, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djshow832 djshow832

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: Add a MockConn to enable testing connections djshow832/tidb
1 participant
@djshow832