Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaitGroup is reused before previous Wait has returned in the TestCacheTablePointGet #30651

Closed
hawkingrei opened this issue Dec 12, 2021 · 2 comments
Assignees
Labels
component/test severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

hawkingrei commented Dec 12, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

make test

[2021-12-12T07:37:40.094Z] --- FAIL: TestCacheTablePointGet (3.24s)

[2021-12-12T07:37:40.094Z] [2021/12/12 15:35:54.132 +08:00] [WARN] [builder.go:4741] ["Update Lock Info Error"]

[2021-12-12T07:37:40.094Z] panic: sync: WaitGroup is reused before previous Wait has returned [recovered]

[2021-12-12T07:37:40.094Z] 	panic: sync: WaitGroup is reused before previous Wait has returned

[2021-12-12T07:37:40.094Z] 

[2021-12-12T07:37:40.094Z] goroutine 2172 [running]:

[2021-12-12T07:37:40.094Z] testing.tRunner.func1.2(0x3792ce0, 0x4172f80)

[2021-12-12T07:37:40.094Z] 	/usr/local/go/src/testing/testing.go:1143 +0x332

[2021-12-12T07:37:40.094Z] testing.tRunner.func1(0xc0051de780)

[2021-12-12T07:37:40.094Z] 	/usr/local/go/src/testing/testing.go:1146 +0x4b6

[2021-12-12T07:37:40.094Z] panic(0x3792ce0, 0x4172f80)

[2021-12-12T07:37:40.094Z] 	/usr/local/go/src/runtime/panic.go:965 +0x1b9

[2021-12-12T07:37:40.094Z] sync.(*WaitGroup).Wait(0xc00553c8f0)

[2021-12-12T07:37:40.094Z] 	/usr/local/go/src/sync/waitgroup.go:132 +0xae

[2021-12-12T07:37:40.094Z] github.com/tikv/client-go/v2/tikv.(*KVStore).Close(0xc00553c7e0, 0x0, 0x0)

[2021-12-12T07:37:40.094Z] 	/nfs/cache/mod/github.com/tikv/client-go/[email protected]/tikv/kv.go:329 +0x47

[2021-12-12T07:37:40.094Z] github.com/pingcap/tidb/store/mockstore/mockstorage.(*mockStorage).Close(0xc001117200, 0x0, 0xc004fbc0e0)

[2021-12-12T07:37:40.094Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/store/mockstore/mockstorage/storage.go:117 +0x45

[2021-12-12T07:37:40.094Z] github.com/pingcap/tidb/testkit.bootstrap.func1()

[2021-12-12T07:37:40.094Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/testkit/mockstore.go:56 +0x66

[2021-12-12T07:37:40.094Z] github.com/pingcap/tidb/table/tables_test.TestCacheTablePointGet(0xc0051de780)

[2021-12-12T07:37:40.094Z] 	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/table/tables/cache_test.go:367 +0xf37

[2021-12-12T07:37:40.094Z] testing.tRunner(0xc0051de780, 0x3dd7c58)

[2021-12-12T07:37:40.094Z] 	/usr/local/go/src/testing/testing.go:1193 +0xef

[2021-12-12T07:37:40.094Z] created by testing.(*T).Run

[2021-12-12T07:37:40.094Z] 	/usr/local/go/src/testing/testing.go:1238 +0x2b3


https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/24306/pipeline

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Dec 12, 2021
@jebter jebter added the sig/planner SIG: Planner label Dec 13, 2021
@yudongusa yudongusa removed the sig/planner SIG: Planner label Dec 14, 2021
@jebter jebter added the sig/execution SIG execution label Dec 14, 2021
@hawkingrei
Copy link
Member Author

/assign

@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

5 participants