Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost performance when locking untouched keys #44332

Open
you06 opened this issue Jun 1, 2023 · 0 comments
Open

Lost performance when locking untouched keys #44332

you06 opened this issue Jun 1, 2023 · 0 comments
Labels
sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.

Comments

@you06
Copy link
Contributor

you06 commented Jun 1, 2023

Enhancement

In the fix #42210, we lock some untouched keys, and there may be high contention when there are conflict on untouched keys, because we don't lock them before, the performance is decreased.

Maybe we can optimize the performance for locking untouched keys if TiDB support a share-exclusive lock, only share lock is required for such case.
@you06 you06 added the type/enhancement The issue or PR belongs to an enhancement. label Jun 1, 2023
@cfzjywxk cfzjywxk added the sig/transaction SIG:Transaction label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfzjywxk @you06