Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: use ART as membuffer #55287

Closed
you06 opened this issue Aug 8, 2024 · 0 comments · Fixed by #56305
Closed

txn: use ART as membuffer #55287

you06 opened this issue Aug 8, 2024 · 0 comments · Fixed by #56305
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@you06
Copy link
Contributor

you06 commented Aug 8, 2024

Feature Request

Is your feature request related to a problem? Please describe:

The membuffer stores written mutations before commit statement, it serves in-txn read also(in union scan), which is a core module of TiDB.

The current implementation is a red-black tree, which is fine, but the performance is such higher in TiDB's use case. Because the keys in TiDB usually have a long common prefix, thus performs not such good in index based on key comparation.

Describe the feature you'd like:

The ART is a radix tree in-mem index, which is friendly to long common prefix keys, in our test, it outperforms the current implementation in almost all cases.

Describe alternatives you've considered:

N/A

Teachability, Documentation, Adoption, Migration Strategy:

To be finished.

Development Tracking

@you06 you06 added the type/feature-request Categorizes issue or PR as related to a new feature. label Aug 8, 2024
ti-chi-bot bot pushed a commit to tikv/client-go that referenced this issue Aug 23, 2024
ti-chi-bot bot pushed a commit to tikv/client-go that referenced this issue Sep 18, 2024
ti-chi-bot bot pushed a commit to tikv/client-go that referenced this issue Sep 23, 2024
ti-chi-bot bot pushed a commit to tikv/client-go that referenced this issue Sep 24, 2024
ti-chi-bot bot pushed a commit to tikv/client-go that referenced this issue Sep 25, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in 65617e5 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant