Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: enhance the ts check considering commit timestamp #57165

Open
cfzjywxk opened this issue Nov 6, 2024 · 0 comments · May be fixed by #57305
Open

server: enhance the ts check considering commit timestamp #57165

cfzjywxk opened this issue Nov 6, 2024 · 0 comments · May be fixed by #57305
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.

Comments

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Nov 6, 2024

Enhancement

After a write transaction is committed, TiDB, as the transaction coordinator, knows the commit_ts used for the write transaction. This timestamp can be used as a reference to check the validity of subsequent read requests’ read_ts. In theory, all read requests occurring after the write transaction should use a read_ts greater than the previous known transaction’s commit_ts.

This approach could help to expose issues like #56809 more quickly.

Besides, this timestamp could be considered for updating the tidb_low_resolution_ts with the known valid timestamps encountered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant