Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log GENERAL_LOG after txnStartTS is set #57256

Closed
b6g opened this issue Nov 9, 2024 · 0 comments · Fixed by #56731
Closed

Log GENERAL_LOG after txnStartTS is set #57256

b6g opened this issue Nov 9, 2024 · 0 comments · Fixed by #56731
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@b6g
Copy link
Contributor

b6g commented Nov 9, 2024

Enhancement

A GENERAL_LOG message is logged before runStmt()

	logStmt(stmt, s)

	var recordSet sqlexec.RecordSet
	if stmt.PsStmt != nil { // point plan short path
		recordSet, err = stmt.PointGet(ctx)
		s.txn.changeToInvalid()
	} else {
		recordSet, err = runStmt(ctx, s, stmt)
	}

So the txnStartTS in a GENERAL_LOG message is usually 0, unless the statement is inside a transaction.

Can we defer logStmt, so that txnStartTS is set and logged, to make the GENERAL_LOG messages more useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant