Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill tidb [session id] can't stop executors and release resources #9831

Closed
qw4990 opened this issue Mar 20, 2019 · 2 comments · Fixed by #9844
Closed

kill tidb [session id] can't stop executors and release resources #9831

qw4990 opened this issue Mar 20, 2019 · 2 comments · Fixed by #9844
Assignees
Labels
sig/execution SIG execution

Comments

@qw4990
Copy link
Contributor

qw4990 commented Mar 20, 2019

Feature Request

Is your feature request related to a problem? Please describe:

When users want to cancel a SQL, they may use kill tidb [session id].
But it can't stop executors since executors don't watch the ctx used to cancel the session and the cancelled session don't call executor.Close() to stop them.
So after kill tidb, these executors will continue to consume resources to do their job.

Describe the feature you'd like:

Background executors should be stopped quickly after kill tidb.

@qw4990 qw4990 added the sig/execution SIG execution label Mar 20, 2019
@qw4990 qw4990 self-assigned this Mar 20, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 20, 2019

I'm working on this now.

@laimisnd
Copy link

laimisnd commented Apr 9, 2019

Meanwhile, is the systemctl restart tidb-4000.service a good enough solution to the query/session kill problem ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants