From 4f5608b5e32bf9ee1b6b927ea75bef342d2471b0 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Wed, 30 Nov 2022 19:14:37 +0800 Subject: [PATCH 1/2] *: data race in the statisticstest Signed-off-by: Weizhen Wang --- tests/realtikvtest/statisticstest/main_test.go | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/tests/realtikvtest/statisticstest/main_test.go b/tests/realtikvtest/statisticstest/main_test.go index 5fef5b584be04..3010d3ee88066 100644 --- a/tests/realtikvtest/statisticstest/main_test.go +++ b/tests/realtikvtest/statisticstest/main_test.go @@ -17,20 +17,9 @@ package statisticstest import ( "testing" - "github.com/pingcap/tidb/testkit/testsetup" "github.com/pingcap/tidb/tests/realtikvtest" - "go.uber.org/goleak" ) func TestMain(m *testing.M) { - opts := []goleak.Option{ - goleak.IgnoreTopFunction("github.com/golang/glog.(*loggingT).flushDaemon"), - goleak.IgnoreTopFunction("github.com/lestrrat-go/httprc.runFetchWorker"), - goleak.IgnoreTopFunction("google.golang.org/grpc.(*ccBalancerWrapper).watcher"), - goleak.IgnoreTopFunction("internal/poll.runtime_pollWait"), - goleak.IgnoreTopFunction("net/http.(*persistConn).writeLoop"), - } - testsetup.SetupForCommonTest() - goleak.VerifyTestMain(m, opts...) realtikvtest.RunTestMain(m) } From 1ee635cb9cbfcd24084c3275f124b613d16a6725 Mon Sep 17 00:00:00 2001 From: Weizhen Wang Date: Wed, 30 Nov 2022 19:18:20 +0800 Subject: [PATCH 2/2] *: data race in the statisticstest Signed-off-by: Weizhen Wang --- tests/realtikvtest/statisticstest/BUILD.bazel | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/realtikvtest/statisticstest/BUILD.bazel b/tests/realtikvtest/statisticstest/BUILD.bazel index 1203b0366c08b..e9d8f215e7939 100644 --- a/tests/realtikvtest/statisticstest/BUILD.bazel +++ b/tests/realtikvtest/statisticstest/BUILD.bazel @@ -12,9 +12,7 @@ go_test( deps = [ "//statistics/handle", "//testkit", - "//testkit/testsetup", "//tests/realtikvtest", "@com_github_stretchr_testify//require", - "@org_uber_go_goleak//:goleak", ], )