Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle-error deal with online ddl #3479

Open
GMHDBJD opened this issue Nov 16, 2021 · 2 comments
Open

handle-error deal with online ddl #3479

GMHDBJD opened this issue Nov 16, 2021 · 2 comments
Assignees
Labels
area/dm Issues or PRs related to DM. subject/new-feature Denotes an issue or pull request adding a new feature.

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Nov 16, 2021

Is your feature request related to a problem?

upstream

set @@sql_mode=''

pt

ALTER TABLE db.tb ADD COLUMN `expect_date` DATE NOT NULL DEFAULT 0;

dm

cannot track ddl: invalid default value 0 for `expect_date`
original ddl: rename /* gh-ost */ table `db`.`tb`` to `db`.`_tb_del`, `db`.`_tb_gho` to `db`.`tb`

Describe the feature you'd like

Though

handle-error <task> replace "ALTER TABLE `db`.`tb` ADD COLUMN `expect_date` DATE NOT NULL DEFAULT '0000-00-00';"

can replace the rename statement to alter statement, the origin online schema meta still remain in DM-worker, which may cause problem.
handle-error skip/replace may need to skip/replace the origin ddl(ALTER statement) in online-ddl.

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response

@GMHDBJD GMHDBJD added the subject/new-feature Denotes an issue or pull request adding a new feature. label Nov 16, 2021
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Nov 16, 2021

cannot track ddl is caused by pingcap/tidb#29795

@GMHDBJD GMHDBJD added type/bug The issue is confirmed as a bug. area/dm Issues or PRs related to DM. and removed subject/new-feature Denotes an issue or pull request adding a new feature. labels Nov 16, 2021
@glorv
Copy link
Contributor

glorv commented Nov 16, 2021

/cc @sunzhaoyang

@GMHDBJD GMHDBJD added subject/new-feature Denotes an issue or pull request adding a new feature. and removed type/bug The issue is confirmed as a bug. labels Nov 16, 2021
@GMHDBJD GMHDBJD self-assigned this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants