DM report "0-1-42 is not mysql GTID set " while upstream is mariadb 10.1.2 with gtid enabled

[XuJianxu]

What did you do?

• create source(mariadb 10.1.2 with gtid enable)
• create task to migrate data
• use query-status to check the task status

What did you expect to see?

task will completed as expect

What did you see instead?

sync process can not conplelted.
worker will report:
[ERROR] [source_worker.go:596] ["failed to up
date source status"] [component="worker controller"] [error="[code=11011:class
=functional:scope=internal:level=high], Message: 0-1-42 is not mysql GTID set"
] [errorVerbose="[code=11011:class=functional:scope=internal:level=high], Mess
age: 0-1-42 is not mysql GTID set\ngithub.com/pingcap/ticdc/dm/pkg/terror.(*Er
ror).Generate\n\tgithub.com/pingcap/ticdc/dm/pkg/terror/terror.go:267\ngithub.
com/pingcap/ticdc/dm/pkg/gtid.(*MySQLGTIDSet).Set\n\tgithub.com/pingcap/ticdc/
dm/pkg/gtid/gtid.go:122\ngithub.com/pingcap/ticdc/dm/pkg/binlog.(*Location).Se
tGTID\n\tgithub.com/pingcap/ticdc/dm/pkg/binlog/position.go:408\ngithub.com/pi
ngcap/ticdc/dm/dm/worker.(*SourceWorker).updateSourceStatus\n\tgithub.com/ping
cap/ticdc/dm/dm/worker/source_worker.go:249\ngithub.com/pingcap/ticdc/dm/dm/wo
rker.(*SourceWorker).QueryStatus\n\tgithub.com/pingcap/ticdc/dm/dm/worker/sour
ce_worker.go:595\ngithub.com/pingcap/ticdc/dm/dm/worker.(*Server).QueryStatus
n\tgithub.com/pingcap/ticdc/dm/dm/worker/server.go:771\ngithub.com/pingcap/tic
dc/dm/dm/pb._Worker_QueryStatus_Handler\n\tgithub.com/pingcap/ticdc/dm/dm/pb/d
mworker.pb.go:2807\ngoogle.golang.org/grpc.(*Server).processUnaryRPC\n\tgoogle
.golang.org/[email protected]/server.go:1082\ngoogle.golang.org/grpc.(*Server).hand
leStream\n\tgoogle.golang.org/[email protected]/server.go:1405\ngoogle.golang.org/g
rpc.(*Server).serveStreams.func1.1\n\tgoogle.golang.org/[email protected]/server.go
:746\nruntime.goexit\n\truntime/asm_amd64.s:1371"]
dm.log

Versions of the cluster

DM version (run dmctl -V or dm-worker -V or dm-master -V):

5.3.1

Upstream MySQL/MariaDB server version:

10.1.2

Downstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

5.3.1

How did you deploy DM: tiup or manually?

(leave TiUP or manually here)

Other interesting information (system version, hardware config, etc):

>
>

current status of DM cluster (execute query-status <task-name> in dmctl)

 # /dmctl --master-addr=127.0.0.1:8261 query-status test-infra
{
    "result": true,
    "msg": "",
    "sources": [
        {
            "result": true,
            "msg": "",
            "sourceStatus": {
                "source": "source-0",
                "worker": "dm-dm-worker-0",
                "result": null,
                "relayStatus": null
            },
            "subTaskStatus": [
                {
                    "name": "test-infra",
                    "stage": "Running",
                    "unit": "Sync",
                    "result": null,
                    "unresolvedDDLLockID": "",
                    "sync": {
                        "totalEvents": "461",
                        "totalTps": "0",
                        "recentTps": "0",
                        "masterBinlog": "",
                        "masterBinlogGtid": "",
                        "syncerBinlog": "(upstream1-bin.000003, 5848964)",
                        "syncerBinlogGtid": "0-1-60",
                        "blockingDDLs": [
                        ],
                        "unresolvedGroups": [
                        ],
                        "synced": false,
                        "binlogType": "remote",
                        "secondsBehindMaster": "0"
                    }
                }
            ]
        }
    ]
}

[lance6716]

If the issue only happens in v5.3.1, the master branch may be accidentally fixed by #4386 . The root cause if when we want to update location A to B, we use A to determine flavor. When A is nil we defaultly use MySQL flavor but the upstream may be MariaDB in fact. After #4386 we use B to determine flavor

[XuJianxu]

attach dm-master log .
dm-master.log
dm-master-1.log
dm-master-2.log

[niubell]

duplicated with #3639

[lance6716]

closed by #4735